helper-cli: Test that curations are added when creating an analyzer results from package lists #9532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
helper-cli-package-list-test-for-curations
branch
from
a61ea3f to
e7db744
Compare
The test reads the ORT configuration from the default location. If the configuration cannot be de-serialized, the test fails. So, isolate that test from any ORT configuration present at the default storage location by generating an ORT configuration. The package curation providers are set to be empty to ensure that the command does not import any package curations (from the respective default storage location). Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
helper-cli-package-list-test-for-curations
branch
from
e7db744 to
e03cc1c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9532 +/- ##
============================================
+ Coverage 67.91% 67.99% +0.07%
Complexity 1290 1290
============================================
Files 249 249
Lines 8818 8818
Branches 917 917
============================================
+ Hits 5989 5996 +7
+ Misses 2440 2433 -7
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nnobelis
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test has been missing back when the functionality was added.
Done in context of: #8739.